Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block containers: fix parsing of trailing whitespace #478

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Nov 17, 2024

fixes #475

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.27%. Comparing base (75e1034) to head (9d70e69).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/c4/yml/parse_engine.def.hpp 97.82% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   97.28%   97.27%   -0.01%     
==========================================
  Files          34       34              
  Lines       11272    11285      +13     
==========================================
+ Hits        10966    10978      +12     
- Misses        306      307       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biojppm biojppm force-pushed the fix/475_trailing_space branch 2 times, most recently from 753107b to 06645a8 Compare January 18, 2025 21:27
@biojppm biojppm force-pushed the fix/475_trailing_space branch from 06645a8 to 9d70e69 Compare January 19, 2025 15:53
@biojppm biojppm merged commit 83595d0 into master Jan 19, 2025
253 of 255 checks passed
@biojppm biojppm deleted the fix/475_trailing_space branch January 19, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing whitespace fails to parse
1 participant